Breaks with ad blocker

[danvk]

@mgiraldo says that disconnect.me prevents the details page from loading.

The solution here might be to do #32, so that I can drop xdomain and do same-domain XHRs for data.

If I take this route, I'd like to do it ASAP so that I'm not mucking with DNS post-launch (DNS changes terrify me).

[danvk]

@mgiraldo if you feel strongly about this, it would help to get some more specifics, e.g. does removing the facebook comment widget make the issue go away?

[mgiraldo]

it works fine in my local instance following the instructions in the README:

i just see it in the hosted version

[mgiraldo]

ReferenceError: FB is not defined in the hosted version

[mgiraldo]

what if we use Disqus or some other non-FB alternative? i know we discussed this as an option

[danvk]

Is it blocking the FaceBook JavaScript bundle? If I open oldnyc.org in Chrome, go to the devtools and type FB, I get an object back. The error you posted would imply that this isn't happening.

[mgiraldo]

correct

On May 13, 2015, at 1:58 PM, Dan Vanderkam notifications@github.com wrote:

Is it blocking the FaceBook JavaScript bundle? If I open oldnyc.org in Chrome, go to the devtools and type FB, I get an object back. The error you posted would imply that this isn't happening.

— Reply to this email directly or view it on GitHub.

[danvk]

This is a bug with disconnect.me then, not with OldNYC. I imagine if you went to facebook.com, nothing would load at all!

[mgiraldo]

ok... i wanted to see if we could avoid FB altogether

it's ok if you want to make it a requirement

[mgiraldo]

FWIW, it does work locally:

your call anyway

[danvk]

Yeah, I don't know why your adblocker would block the facebook JS in one case but not the other.