search

danvk / oldnyc

Mapping photos of Old New York
Apache License 2.0
288 stars 132 forks source link

about link should not open embedded #80

Open mgiraldo opened 9 years ago

mgiraldo commented 9 years ago

the behavior of the about link should be like that of a normal link

danvk commented 9 years ago

This was specifically requested at our last meeting—did something change?

mgiraldo commented 9 years ago

what was requested? that it be shown embedded in the map?

i created a pull request with a bunch of changes including this (although doesnt have the JS.... for some reason my JS changes do not work)

danvk commented 9 years ago

maybe you need to comment the bundled.js <script> and uncomment the individual ones in viewer.html?

mgiraldo commented 9 years ago

maybe... i don't know... i am not familiar with the way the site is built... i try to change things so that you dont have to do that but i reach some wall and cant look too much into the cabling

danvk commented 9 years ago

You can also run ./update-js-bundle.sh if you prefer.

On Fri, May 15, 2015 at 4:56 PM Mauricio Giraldo notifications@github.com wrote:

maybe... i don't know... i am not familiar with the way the site is built... i try to change things so that you dont have to do that but i reach some wall and cant look too much into the cabling

— Reply to this email directly or view it on GitHub https://github.com/danvk/oldnyc/issues/80#issuecomment-102524121.