search

danvk / oldnyc

Mapping photos of Old New York
Apache License 2.0
288 stars 130 forks source link

:space_invader: lots of changes in css #81

Closed mgiraldo closed 9 years ago

mgiraldo commented 9 years ago
danvk commented 9 years ago

Can you include a screenshot of your changes?

mgiraldo commented 9 years ago

oldnyc - historic photographs of new york city-1 oldnyc - historic photographs of new york city-2

about oldnyc

about oldnyc-1

danvk commented 9 years ago

I'm not sure about that font—is it a comic font?

mgiraldo commented 9 years ago

https://typekit.com/fonts/rooney-sans

danvk commented 9 years ago

Closed in favor of #86.

Let me know if including the NYPL logo is a hard requirement. I'd probably put it in the lower left of the page if so.

mgiraldo commented 9 years ago

it is

mgiraldo commented 9 years ago

this request also includes changes to the about page and the header. are you including those in #86?

danvk commented 9 years ago

I've added the logo in a separate PR.

re: header, are you referring to the tagline? ("Mapping historical photos from the NYPL"?) I talked with Shana about tightening this up and she was fine with the shorter version. I don't see any reason to go back to the longer tagline.

re: about page, I think you're right about just having it open in a new tab. I misunderstood the NYPL request to make it "feel like part of the site". Can you summarize what your changes were other than that? It looks like you changed the font, made the links read and made the body much narrower?

mgiraldo commented 9 years ago

re about:

you can see the changes here https://github.com/NYPL/oldnyc/commit/31e9360ee4e21d25b000021a2db9579c79a63cac

On May 19, 2015, at 13:00, Dan Vanderkam notifications@github.com wrote:

I've added the logo in a separate PR.

re: header, are you referring to the tagline? ("Mapping historical photos from the NYPL"?) I talked with Shana about tightening this up and she was fine with the shorter version. I don't see any reason to go back to the longer tagline.

re: about page, I think you're right about just having it open in a new tab. I misunderstood the NYPL request to make it "feel like part of the site". Can you summarize what your changes were other than that? It looks like you changed the font, made the links read and made the body much narrower?

— Reply to this email directly or view it on GitHub.

danvk commented 9 years ago

is my summary accurate?

mgiraldo commented 9 years ago

among the changes:

  1. floated images to the right, added more margins and made them same width and appearance
  2. removed link in header
  3. added a link to the main page below header
  4. changed the typeface
  5. made ordered lists design consistent with unordered ones
  6. fixed heading hierarchy
  7. made text column width more readable
  8. layout responds well to different window widths