danvk / oldnyc

Mapping photos of Old New York
Apache License 2.0
288 stars 130 forks source link

Host over https #88

Closed danvk closed 1 month ago

danvk commented 9 years ago

GitHub pages supports it. CloudFlare supports it.

Loading oldnyc-assets.nypl.org over https is less clear. @riordan do you guys have a secure endpoint for the images?

danvk commented 9 years ago

I set up images.oldnyc.org to be an alias for oldnyc-assets.nypl.org using CloudFlare. If it's added as a valid CNAME for oldnyc-assets.nypl.org, then https might just work.

Sample URL: http://images.oldnyc.org/600px/708760f-a.jpg

riordan commented 9 years ago

Did you just CDN a CDN, Dan?

sorry I didn't respond to this way back when.

Can't get the CNAME added now, but @mgiraldo or @hadro might be able to get it taken care of. That would require getting Brett to add it as a CNAME. Other option is to just serve it from the Cloudfront distribution URL, which shouldn't be hard for someone in the labs team to track down.

mgiraldo commented 9 years ago

this should be happening now... some propagation might be taking place... it was previously set to someidnumber.cloudflare.net

mgiraldo commented 9 years ago

looking at things here and it seems that the links broke... i will make the change locally in aws

mgiraldo commented 9 years ago

ok made the change in AWS. propagating...

mgiraldo commented 9 years ago

verified: http://images.oldnyc.org/600px/708760f-a.jpg https://images.oldnyc.org/600px/708760f-a.jpg http://oldnyc-assets.nypl.org/600px/708760f-a.jpg

hadro commented 9 years ago

Nice! Thank you all.

On Tue, Jun 23, 2015 at 3:35 PM, Mauricio Giraldo notifications@github.com wrote:

Closed #88 https://github.com/danvk/oldnyc/issues/88.

— Reply to this email directly or view it on GitHub https://github.com/danvk/oldnyc/issues/88#event-338196013.

danvk commented 9 years ago

Reopening since oldnyc.org itself isn't hosted over HTTPS yet :)

Thanks for the help guys!

danvk commented 1 month ago

oldnyc.org has been served over https for quite a while now