danvk / source-map-explorer

Analyze and debug space usage through source maps
Apache License 2.0
3.83k stars 101 forks source link

VSCode opened instead of a browser #121

Closed Vinnl closed 5 years ago

Vinnl commented 5 years ago

Description When running source-map-explorer, instead of opening a browser displaying the output, it opens a new instance of VSCode (not with the report open).

Steps to reproduce I'm not sure where s-m-e looks to determine the browser, so it's probably something specific to my system (Ubuntu) - I just don't know where to look. In any case, VSCode is not the default application for HTML files, and other apps manage to open my default browser just fine.

Files to reproduce N/A, I guess.

Expected behavior Either a browser window to open, or a message that that wasn't possible, with instructions on where I can find the output to open it myself.

Environment

Additional context I initially thought it didn't work at all.

nikolay-borzov commented 5 years ago

Try 2.0.1

Vinnl commented 5 years ago

Still happens with 2.0.1, unfortunately...

Vinnl commented 5 years ago

That did point me to the fact that the open npm package was used, which defers to xdg-open (which defers to gvfs-open on GNOME), which apparently had a different default application set up for HTML files than my file manager had. Setting that to Firefox as well (gio mime text/html firefox.desktop) fixed this. Thanks!