Regenerate test files - Githubissues

danvk / source-map-explorer

Analyze and debug space usage through source maps

Apache License 2.0

3.83k stars 101 forks source link

Regenerate test files #129

Closed also closed 5 years ago

also commented 5 years ago

This regenerates some test files in tests/data to fix #128.

I tried to keep the generated code similar to the original, and checked in a small package in tests/generate-data that can be used to regenerate the data. I'm not that familiar with the browserify ecosystem, so this package might be a little weird.

The source map comments that were previously attributed to dist/bar.js are now unmapped. This causes a warning. foo.min.js and inline-map.js results are now the same aside from unmapped bytes.

coveralls commented 5 years ago

Coverage decreased (-0.4%) to 97.887% when pulling 06ae376870af717d1b4d07f19e93dc60e92f287d on also:fix-tests into 3299395ded603ceb8bb3dc40f284f7ed08398c74 on danvk:master.

nikolay-borzov commented 5 years ago

Please use the following commit message format

Regenerate test files (#129)

- What has been done and why
- More details

I should've added this to contribution guide

nikolay-borzov commented 5 years ago

@also, please squash all commits using format for message

Summary (#<Issue ID>)

- What have been done
- Additional details
- Additional details

For example

Regenerate test files (#128)

- Regenerate test js and source map file in order to fix invalid source maps
- Add `generate-data` app that contains original source files and generates some of tests data files

also commented 5 years ago

You beat me to it. Thanks!