Fix slowness - Githubissues

nikolay-borzov commented 4 years ago

Remove useless false-positive check for source map referencing EOL. Creating string with the length of the file on each iteration greatly decrease performance
Disable check for invalid mapping column until #136 is fixed
Update InvalidMappingColumn error message - add 1 to generatedColumn to count columns from 1 to conform with contains ${maxColumn} column(s) phrase
Reduce usage of map-reference-eol.js in tests
Generate invalid-map-column.js and invalid-map-line.js without tsc to eliminate source map referencing EOL

Fixes #158

coveralls commented 4 years ago

Coverage decreased (-0.8%) to 95.863% when pulling bca201cf582f54a677a73bb8a1ce837855d8f2db on fix-slowness into 8a1d7f05a236870d5489b4e68d2deae633094cb8 on master.

danvk commented 4 years ago

Looks great @nikolay-borzov , thanks for tracking down the string concatenation issue!

Should we have a performance test to make sure this doesn't regress?

nikolay-borzov commented 4 years ago

Yeah, that was my fault actually.

I thought about the performance test but haven't figure out how to implement it yet. Should it be just measuring big source map processing time (outside main code) or adding measures to several places in code? I've created #166 to address it.

danvk / source-map-explorer

Fix slowness #165