Enable focusing parent node via escape key

danvk / source-map-explorer

Analyze and debug space usage through source maps

Apache License 2.0

3.82k stars 100 forks source link

Enable focusing parent node via escape key #187

Closed diminutivesloop closed 4 years ago

diminutivesloop commented 4 years ago

This makes navigating back out after focusing on a child node easier by avoiding the need to move the mouse to a narrow target at the top of the page.

coveralls commented 4 years ago

Coverage remained the same at 97.899% when pulling 771796ecc472bbeedde0d67729675f4dad2df61c on diminutivesloop:escape-key-support into 73214835c8c2961aa8216db24563c927f81373da on danvk:master.

nikolay-borzov commented 4 years ago

Please read https://github.com/danvk/source-map-explorer/blob/master/CONTRIBUTING.md. webtreemap will be replaced with foamtree in 2.5.0

diminutivesloop commented 4 years ago

Glad to hear it! Foamtree should provide a much better visualization experience. BTW I’m not sure what the link to CONTRIBUTING.md is for since I don’t see any mention of foamtree and it doesn’t appear I violated any of the guidelines. Either way I’ll go ahead and close this PR.

nikolay-borzov commented 4 years ago

Before you start Create an issue describing improvement/bug.

It's better to create an issue before doing any work. This way we can save time