search

danvk / source-map-explorer

Analyze and debug space usage through source maps
Apache License 2.0
3.83k stars 101 forks source link

count each byte, instead of min/max #57

Closed ersimont closed 7 years ago

ersimont commented 7 years ago

This is the recommended edit from https://github.com/danvk/source-map-explorer/issues/47#issuecomment-294031794

danvk commented 7 years ago

Thanks for the PR @ersimont. Did you notice this comment? I'd like to figure out what's going on there before merging a fix.

ersimont commented 7 years ago

I did notice it, and I have no idea what to say about it. Sorry! All I did was try out your recommended fix and run a few small bundles through it to see if it looked ok-ish. I'll need to rely on you and/or others to vet it more fully! I only offer the PR to save others the time of making the actual change.

danvk commented 7 years ago

Fair enough, I wish I'd included more context in that comment! If you could fix the failing test (it's an eslint issue) then I'll see if I can reproduce the oddness tomorrow.

ersimont commented 7 years ago

Fixed. Thanks for explaining it was ESLint, because I could not tell from the Travis output on my own!

Ah - looking at it again now that I know what the problem was, the error message makes perfect sense. :)