search

danvk / source-map-explorer

Analyze and debug space usage through source maps
Apache License 2.0
3.83k stars 101 forks source link

Add API #73

Closed jakub300 closed 6 years ago

jakub300 commented 6 years ago

Closes #72

Hi, it may be bigger than expected, let me know what do you think. I was trying hard to not break anything in cli but I might have. Also I noticed that for me (Mac OS 10.13.2) cli does not exit after opening browser which is due to switch to opn. It is something you may want to look into.

danvk commented 6 years ago

Thanks @jakub300! And thanks for the heads-up about opn. It looks like that can be fixed by passing { wait: false } as an option.

Overall this looks great and I appreciate the new tests. One question: why change the find/replace to use an object instead of the two arrays?

jakub300 commented 6 years ago

I felt that it would be weird to pass two arrays to function. We could also accept both and if object is passed transform it to arrays. I can update it whichever way you prefer.

dylang commented 6 years ago

@jakub300 @danvk Anything I can do to help get this in?

I'm happy to make a new PR with the changes I suggested.

I understand if you've been too busy, I'm the same with my open source projects.

danvk commented 6 years ago

@dylang fine with me if you'd like to take it over (and also if you'd like to become a contributor to this project).

jakub300 commented 6 years ago

Hey, I'm in the process of addressing @dylang feedback. It will be ready within hour or two.

danvk commented 6 years ago

Cool. Happy to make you a contributor, too, @jakub300 .

jakub300 commented 6 years ago

Hey @dylang, sorry for the late response. Thank you for you in depth feedback. Most of it should be addressed. In few cases I addressed them differently. Let me know what do you think.

jakub300 commented 6 years ago

@dylang Happy to hear that. Typo fixed.

@danvk I appreciate the offer but I still struggle to find time after work for open source so I'm not interested right now.

danvk commented 6 years ago

Merged. Thanks for this addition, @jakub300! I'll cut a release on npm later today.

@dylang Thanks for helping out with this. Let me know if you'd like to be added as a contributor to this repo.

lencioni commented 6 years ago

@danvk it looks like this hasn't been published yet. Any chance you can publish a new version?

danvk commented 6 years ago

@lencioni it's been published as 1.6.0. Sorry for the delay.

@jakub300 @Hypercubed @dylang if any of you would like to be added as collaborators on npm (or this GitHub repo) please let me know!

lencioni commented 6 years ago

@danvk no worries! Thanks for your work here! 💕

lencioni commented 6 years ago

FYI, I just put this up: https://github.com/lencioni/remote-source-map-explorer

If you are interested in incorporating this into source-map-explorer, feel free to steal code or let me know and I can work on a PR or something.