search

danvk / source-map-explorer

Analyze and debug space usage through source maps
Apache License 2.0
3.83k stars 101 forks source link

Combined bundle #83

Closed danvk closed 5 years ago

danvk commented 5 years ago

Here's the new default view when I run SME with four bundles: main, histogram, scatter and mapbox: image

Selecting a specific bundle from the dropdown or clicking it in the tree map have essentially the same behavior.

Also sets page language (Chrome kept offering to translate the result page from Danish!)

@nikolay-borzov let me know if you think this makes sense

nikolay-borzov commented 5 years ago

Looks great

nikolay-borzov commented 5 years ago

I wonder when are you planning to publish a release with these change?

danvk commented 5 years ago

@nikolay-borzov sorry, it's been on my to-do list the past week. If you're interested, I'm happy to make you an owner.

nikolay-borzov commented 5 years ago

That would be great. Not sure I can find much time to contribute though

nikolay-borzov commented 5 years ago

Could you please publish a new version?

danvk commented 5 years ago

@nikolay-borzov I added you as a GitHub collaborator. If you can share your NPM login I'll add you there, too.

I'll try to roll out a release in the next hour or so, but if I don't in the next day or so then feel free to do so yourself.

nikolay-borzov commented 5 years ago

Great! My npm login chinstu

danvk commented 5 years ago

Great, done!

One thing I would like to fix, which could be in a follow-up release: I'd like source-map-explorer *.js and source-map-explorer '*.js' to do the same thing. Only the latter works right now, which I find quite confusing. I actually just spent the last 15 minutes trying to figure out why I couldn't get this to run with multiple bundles!

nikolay-borzov commented 5 years ago

Strange, for it works for me without quotes, but cannot find a file if surrounded by quotes. Maybe it's OS dependent somehow

node index.js C:\develop\test\app\build\static\js\*.*
danvk commented 5 years ago

@nikolay-borzov released 1.7.0 to NPM: https://www.npmjs.com/package/source-map-explorer