search

danvk / source-map-explorer

Analyze and debug space usage through source maps
Apache License 2.0
3.83k stars 101 forks source link

v1.7.0 requires node v8 #86

Closed jakub300 closed 5 years ago

jakub300 commented 5 years ago

Hi we noticed that newly created projects started breaking on our CI that is still using node v6 with following error:

/[redacted]/node_modules/source-map-explorer/index.js:463
      ...result,
      ^^^
SyntaxError: Unexpected token ...

It is referring this code: https://github.com/danvk/source-map-explorer/blob/dad76525f0d0928aab205eb4d9b0c16d875bad92/index.js#L462-L465

danvk commented 5 years ago

I'd be happy to merge a PR that changed this, but it looks like node 6 is being end-of-lifed next month anyway. Might be time to update! https://github.com/nodejs/Release On Thu, Feb 21, 2019 at 8:43 AM Jakub Bogucki notifications@github.com wrote:

Hi we noticed that newly created projects started breaking on our CI that is still using node v6 with following error:

/[redacted]/node_modules/source-map-explorer/index.js:463 ...result, ^^^ SyntaxError: Unexpected token ...

It is referring this code:

https://github.com/danvk/source-map-explorer/blob/dad76525f0d0928aab205eb4d9b0c16d875bad92/index.js#L462-L465

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danvk/source-map-explorer/issues/86, or mute the thread https://github.com/notifications/unsubscribe-auth/AAF__fS6Aq-diTJGsl-NJ1v04XaPFqyuks5vPqJ7gaJpZM4bHdwu .

jakub300 commented 5 years ago

Fair enough but it should be semver major release

nikolay-borzov commented 5 years ago

You can continue using v1.6.0. Sorry, but I don't think we should stick with node 6 support

mikeerickson commented 5 years ago

Seeing as we are already on Node 11, setting a minimum of Node 8 is plenty logical to me. You have to make a decision as some point as to how much backwards compatibility you want to support, and at what time you wish to take advantage of modern features.

I think requiring Node 8 is a good decision (I have been at this same crossroad before)

jakub300 commented 5 years ago

While I don't disagree that Node 6 life is ending and we should update, the goal of semver is to ensure that situations like our do not happen. Dropping the support for older Node versions is backward incompatible change and should be released accordingly.

Feel free to close this issue if you don't intend to take any action.

danvk commented 5 years ago

@jakub300 Your point about semver is well-taken and we'll keep it in mind in the future. If you'd be interested in getting SME working with Node 6 I'd be happy to merge a PR and cut a 1.7.1 release. But otherwise, given that node 6 is so close to EOL, I'd prefer to leave things as-is.