[Feature/storage] Cleanup of previous threads fix. Fix longstanding sort order

danvratil / harbour-sailslack

Unofficial Slack client for Sailfish OS

GNU General Public License v3.0

4 stars 4 forks source link

[Feature/storage] Cleanup of previous threads fix. Fix longstanding sort order #40

Closed b100dian closed 1 year ago

b100dian commented 1 year ago

The first commit is going to be cherry-picked in master too.

The rest is a cleaner attempt at last time where I removed the 'thread leader' from the list, plus making an Assert tolerant to messages having parent messages, plus fixing another assert / crash by changing the caller's messages list. The last's approach is debatable, so I'm open to suggestions.

b100dian commented 1 year ago

I'm closing this as I had:

build errors because of lack of qpm that made me merge the feature/storage branch from master
attention span problems since with the above merged build I'm not seeing whatever problem I was solving yesterday (before all the wait! build is not working! PRs)
Will re-open once I get my thoughts clear. Right now the empty channel (multi-im?) messages seem to be priority for this branch.

danvratil commented 1 year ago

Feel free to open new issues with whatever problem you run into, even if it's just a braindump. We can always triage or close them later :)