danvratil / qcoro

C++ Coroutines for Qt
https://qcoro.dvratil.cz
MIT License
331 stars 53 forks source link

Make how Qt packages are found more convinient #162

Closed DeveloperPaul123 closed 1 year ago

DeveloperPaul123 commented 1 year ago

This change allows users to specify Qt5_DIR or Qt6_DIR and then the rest of the components are automatically found. Prior to this, since find_package() was called for each component of Qt, CMake configuring would fail with each component not found. So you would have to specify all the paths at once.

I'm not sure if find_package(Qt${ARGS_QT_VERSION}${base_component} REQUIRED COMPONENTS Private) is needed, but if so I can add it back in. From my testing, things worked as expected.

danvratil commented 1 year ago

Thanks, Paul!