danvratil / qcoro

C++ Coroutines for Qt
https://qcoro.dvratil.cz
MIT License
331 stars 53 forks source link

DBUILD_SHARED_LIBS missing form cmakeList #230

Closed reg31 closed 1 month ago

reg31 commented 1 month ago

Hi,

I do not have the option to build qcoro as shared library in cmake.

danvratil commented 1 month ago

It's a CMake variable, so I did not explicitly mention it in my CMakeListst.txt. But passing -DBUILD_SHARED_LIBS=ON to CMake should work just fine to build QCoro as shared libraries. Or it doesn't work for you? Could you please share the cmake command you are using and full output from CMake?

reg31 commented 1 month ago

It's ok, I've just added option(BUILD_SHARED_LIBS "Build using shared libraries" ON) to the cmakelist and it worked.

danvratil commented 1 month ago

Closing the issue, you can either add the option or just pass -DBUILD_SHARED_LIBS=ON to cmake when configuring QCoro.