Serialization robustness & correctness

danwallach / ElectionGuard-TypeScript

TypeScript implementation of ElectionGuard (subset for ballot encryption)

MIT License

8 stars 0 forks source link

Serialization robustness & correctness #11

Closed danwallach closed 2 years ago

danwallach commented 2 years ago

Deserialization --> what if a required field is missing? (@Transform annotations, e.g., in chaum-pedersen code)
Compatibility with the latest schema from Microsoft

shreyasminocha commented 2 years ago

In section 4.1.4, the v1.02 spec says that the is_write_in field is a string. It's supposed to be a boolean, though, right?

danwallach commented 2 years ago

Definitely should be a boolean. Please double-check the Microsoft Python code. If they've got a boolean, we'll go with it. If they've got a string, then we'll still go with boolean but also file a bug against them.

Meanwhile, I'm working on a hacl-wasm fork, trying to integrate Microsoft's HACL-WASM, which promises significant performance improvements. Feel free to poke around, but right now, it's in a very fragile state.

shreyasminocha commented 2 years ago

Do we need codecs for the classes in submitted-ballot.ts and plaintext-ballot.ts? I'm working on the ballot-serialization branch, by the way.

danwallach commented 2 years ago

Yeah, we're going to need codecs for all that stuff. I'm meanwhile working on the main branch and will soon be pushing a big chunk of new code to deal with encryption and decryption, plus a ton of tiny changes elsewhere. Please don't merge anything yet.