Make async elgamal work

danwallach commented 2 years ago

Lots of effort to get async encryption working, but now it all seems happy. Some of the nasty problems included:

mixing and matching of the 3072 and 4096-bit groups (initially presented itself as a deserialization issue, which dragged me wildly off track before isolating the problem)
using the wrong value for the nonce field of the CiphertextBallot
renamed a few class members to be more consistent with their Python equivalents
our logging subsystem was invaluable, but for some reason the afterAll part was executing before the tests were complete, resulting in some complaints from Jest. (Why? Unclear.)

I'm nowhere near sure that we're bug-for-bug compatible with the Python code, but at least we're kinda sorta actually working.

shreyasminocha commented 2 years ago

but for some reason the afterAll part was executing before the tests were complete, resulting in some complaints from Jest. (Why? Unclear.)

Figured it out: fast-check expects you to await fc.assert when asserting and async property.

danwallach commented 2 years ago

Cool. Async stuff in TypeScript can be wildly non-obvious.

danwallach / ElectionGuard-TypeScript