rollup / packaging issues

[danwallach]

Right now, when you run npm run test, it proceeds to start running the packaging process. Dunno why that's happening, but something's not right.

There are also warnings about circular dependencies and about this being rewritten to undefined, so I'm assuming that we've still got some effort to get this all buttoned up.

[shreyasminocha]

warnings about circular dependencies

This one is related to our use of Buffer in hash.ts, and it looks like there's not much we can do about it, short of getting rid of our use of Buffer (https://github.com/FredKSchott/rollup-plugin-polyfill-node/issues/21, https://github.com/calvinmetcalf/rollup-plugin-node-builtins/issues/39). Seems to be harmless.

Also related to this issue is removing the compile npm script which individually transpiles our typescript files. I think we need it to run bench/*.ts, but we could replace that with ts-node (blocked by an upstream packaging issue with bigint-mod-arith). Apart from that though, it seems redundant now from what I can tell.

[danwallach]

Can we get rid of Buffer? Just use string concatenation?

bigint-mod-arith is a remarkably small package and we're only using a small part of it. We could just decide to copy that into our own code, so long as the license is compatible.

[shreyasminocha]

Closing in favour of #34 and #35. As far as I can tell, the builds work. We now support:

• node (both import and require)
• post-bigint browsers (both as an ES module and as a global named eg)
• deno