better phpcs

[danwdart]

Better PHPCS

Use a newer standard and more sniffs so we can detect and auto-fix things like:

• strict_types isn't missing
• typehints (including scalar) are always present unless the hungarian notation variable name starts with "mixed"
• return types are always present
• docblocks are present and correct
• PSR-1 and PSR-2 stuff like "classes are CamelCased, methods are lowerCamelCased"
• variable names are lowerCamelCased
• always use double quotes
• protect against backtick operator
• protect against raw SQL everywhere if poss.
• constants are always uppercased and underscored
• Test files' public methods' names should only begin with "test"
• Common class names are only in "use" statements and are not littered about classes
• Everything is NS'd (& exceptions are logged)
• Duplicate code is all in mixins
• mocks are named/unambiguous/etc
• etc.

PSR-1: http://www.php-fig.org/psr/psr-1/ PSR-2: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md

[danwdart]

Seems that PSR1, PSR2, SlevomatCodingStandard and Squiz includes most of the things here. Except:

protect against backtick operator protect against raw SQL everywhere if poss. Test files' public methods' names should only begin with "test" Common class names are only in "use" statements and are not littered about classes Everything is NS'd (& exceptions are logged) Duplicate code is all in mixins mocks are named/unambiguous/etc

[danwdart]

Many of these conflict with existing standards trees, would be better to find an interactive chooser so that none of the overrides clash with each other.