Incorrect text for non-english browsers when replies received but quorum not achieved

[daveschaefer]

In process_notary_results(), one of the 'if' statements searches for a hard-coded english string "ssl key". Originally this string was added by Pers_xml.resultToString() when a notary send back results. But the hardcoded string was removed from resultToString() as part of the work to remove all localized strings - and the corresponding search in process_notary_results() was not updated.

Thus, If Perspectives is running in a english language browser, it properly finds the string and displays the correct status. If the browser is not english, Perspectives never finds the sentence it is looking for, so the code skips down to and displays the wrong text.

This happens when some replies were received but not enough to achieve quorum.

All the more reason to get all hardcoded english strings removed, but perhaps we want to track this check with a flag or boolean that is set by code, so it doesn't depend on a particular string anyway.

None of the remaining hardcoded strings that are marked for removal seem to be used for any calculations or statements like this. However there could be some hardcoded strings I missed.

Repro steps:

• Use a non-english browser (To easily change the setting, open 'about:config' and edit the 'useragent.locale' setting to any supported Perspectives locale, such as 'es-MX')
• If necessary, add a fake notary that will not send any reply (you can simply copy/paste an existing key and make up a notary DNS name)
• Visit any site that will not achieve quorum (you can set your quorum to be extremely high to achieve this if necessary)
• Note that even though replies are listed in the results chart, the mouseover text claims that Perspectives received no replies

[ghost]

Uhm, lol :) A quick fix would be to check against Perspectives.strbundle.getString("sslKey") in process_notary_results() for now, but I think you are right about using a flag. I made several changes in the embedded_content branch and will use the quick fix for now until the embedded_content functionality found it's way to the master.

[daveschaefer]

A quick fix would be to check against Perspectives.strbundle.getString("sslKey")

Yes, that's exactly what I did in my patch too :)

I have code to fix this ready to go in a branch; we should reconcile our diffs and get on the same page once I have a bit of time.