danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

Lambdor pr 124 #144

Closed daveschaefer closed 9 years ago

daveschaefer commented 9 years ago

This is a copy of PR #124 , merged back into the main branch, and with some tweaks and changes.

@lambdor - Feel free to review or comment on my changes added here. Because of #143 I propose we do the following:

Comments welcome.

ghost commented 9 years ago

So the 'distrust' functionality is not directly related to the badRecentCerts functionality, but with badRecentCerts removed it could cause a less-than-ideal user experience. With the badRecentCerts code branch disabled, any site using a certificate that is not blessed by the CA system will outright prevent Firefox from browsing there. So right now if we distrust all certs firefox won't browse anywhere :( and the current Perspectives code won't be able to override that. So I'm thinking we should fix the cert overrides first before exposing it. Thoughts?

I understand. Ok, disable for now.

Rest is approved.

daveschaefer commented 9 years ago

Ran through the full manual test suite and made one other change. Merging!