search

danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

Make statusbar icon optional (or remove it) #38

Closed Ede123 closed 12 years ago

Ede123 commented 13 years ago

Hi,

since there's a new toolbar icon that can be placed everywhere, the old statusbar icon should be optional or removed completely.

Thanks Ede

daveschaefer commented 12 years ago

Hey, I'll volunteer to fix this. I propose we chop out the {statusbar} xul element altogether and rely solely on the {toolbarbutton}. Please take a look at 2c74919583feac1a4d7d1030398bbdcf5a8234ca .

I tried out Firefox 3.6.4 and it looks like it can handle {toolbarbutton}s just fine. If we really wanted we could split up the .xuls to use one set of elements for old browsers and one set for current versions (ala this article), but it looks like firefox versions before 4 will be unsupported and unmaintained soon, so I'm not sure if it's worth it.

daveschaefer commented 12 years ago

This has been pulled in https://github.com/danwent/Perspectives/pull/54 (thanks Dan! :), and I'll close the ticket once we publish a new version. @Ede123 (or anyone) feel free to comment with whether the new version works/doesn't work for you.

Ede123 commented 12 years ago

Works great thanks.

I allready installed a development build 3 months ago an was using the fix allready for 3 months now. :)

daveschaefer commented 12 years ago

Thank you for the reply! That is fantastic :)

daveschaefer commented 12 years ago

4.3 has been released; closing this