danwent / Perspectives

Perspectives Firefox Extension
http://perspectives-project.org
66 stars 19 forks source link

Extract hard-coded strings for localization #46

Closed daveschaefer closed 12 years ago

daveschaefer commented 12 years ago

There are several hard-coded English strings left in the code. We should move these out to the .dtd and .properties files so they can be localized.

daveschaefer commented 12 years ago

I've begun work on this.

daveschaefer commented 12 years ago

Okay, let's see

  1. ee55781259b303c4e1bac26bb1634d36e7e20744 'Add to Whitelist' code and form
  2. 40ce77079b93ad0ce3209308ab5faf43c7e9c072 and 153f6eb602b65defddeb39631ff18c80012b2d9e 'Report Attack' code and form
  3. b3f5d768d84ee7a81001411645d653ee73c69856 Notary Results code and form
  4. bd6fdd9d2793d35c917df8163b003592700763dc Notary Results image
  5. a18eebd86a7152fa6f960b8c4d24130dd6a4968f Preferences form
  6. 7286ef27fa52647503bbb078ec2d4880f7bb95a8 Statusbar/Menu items
  7. fbecdbf5e40714dcbc1b3549600fc00902b3faea various notify strings
  8. 4470bed28709f3e688f227b16bccae54898d73a4 common.js
  9. Mostly done: bccd8dbe7cd3ca61092f436a81a176bbedb9425e , 153f6eb, 90dace notaries.js
  10. a6179 xml_notary_client.js

Also:

daveschaefer commented 12 years ago

Okay, this is mostly done! 12 strings remain in notaries.js, but some of them are obscure and I'm not sure how to cause/reproduce them. I'm uneasy replacing strings that I can't test. So I vote we go ahead translating with this 99% and fix the remaining 12 strings as we are able.

daveschaefer commented 12 years ago

Some of the remaining strings are part of error messages that only happen if we are unable to load a valid localization file. Attempting to load another (potentially invalid) localization file as part of the error handling for that case doesn't seem like a good idea ;)... so a few of the 12 will be left as hard-coded English. If that causes problems for non-English speakers reporting bugs we should look into another solution.

Created new milestone 4.3.1 for this so we can release the localization as a 'minor' update.

daveschaefer commented 12 years ago

More strings - Moved firewall.html into firewall.xhtml and extracted strings as part of 052ec8b3 . Moving this ticket to 4.4 now so we can publish 4.3.1 without bothering our awesome translators for more strings (yet)

daveschaefer commented 12 years ago

Moving to 4.3.2 so we have something attached to the milestone. I created https://github.com/danwent/Perspectives/issues/58 to track removing the remaining strings.

daveschaefer commented 12 years ago

4.3.2 has been submitted! :)