search

danwha / MaskPassword

This is a suggestion for passwords that change over time, not always a constant string of passwords.
MIT License
3 stars 2 forks source link

Contributing to Opensource #1

Open iamgabrielsoft opened 3 years ago

iamgabrielsoft commented 3 years ago

I want to contribute to this project

danwha commented 3 years ago

Thank you for your interest in MaskPassword. Anything to make it better is welcome. You don't have to ask for my consent. However, you only need to indicate that the draft is me. I'm not familiar with github. - If I need to do something, please tell me.

iamgabrielsoft commented 3 years ago

Sounds cool, would hit you up when am done!

danwha commented 3 years ago

Sounds cool, would hit you up when am done!

I'll be waiting.

Well... I designed a function that allows authentication only at a specific date and time. However, I canceled it because I didn't feel the need to implement it.

iamgabrielsoft commented 3 years ago

Yeah sure, i simply modified the codes...

Unable to push now, am getting this error: fatal: unable to access 'https://github.com/danwha/MaskPassword.git/': The requested URL returned error: 403

Probably you achieved the repo

iamgabrielsoft commented 3 years ago

Though i want to setup a travis file for the project

iamgabrielsoft commented 3 years ago

Sounds cool, would hit you up when am done!

I'll be waiting.

Well... I designed a function that allows authentication only at a specific date and time. However, I canceled it because I didn't feel the need to implement it.

On this, they isn't a backend implementation here, i don't think it would be needed 😜

danwha commented 3 years ago

On this, they isn't a backend implementation here, i don't think it would be needed 😜

Yes. It's actually made for backend in node.js. It is an incidental degree that can be used in react.js while applying es6.

iamgabrielsoft commented 2 years ago

Yeah sure

On this, they isn't a backend implementation here, i don't think it would be needed 😜

Yes. It's actually made for backend in node.js. It is an incidental degree that can be used in react.js while applying es6.

Exactly

iamgabrielsoft commented 2 years ago

Yeah sure, i simply modified the codes...

Unable to push now, am getting this error: fatal: unable to access 'https://github.com/danwha/MaskPassword.git/': The requested URL returned error: 403

Probably you achieved the repo

How about this @danwha ??☝️☝️☝️☝️

danwha commented 2 years ago

Yeah sure, i simply modified the codes... Unable to push now, am getting this error: fatal: unable to access 'https://github.com/danwha/MaskPassword.git/': The requested URL returned error: 403 Probably you achieved the repo

How about this @danwha ??☝️☝️☝️☝️

I have no idea. I am using VSC on iMac, and it is connected to github but not deployed. After trying several times, I gave up. It was very convenient and easy to upload just by file upload in the browser. 😁

iamgabrielsoft commented 2 years ago

It's but I can't seem, but using the command line is alot simpler.

Why not make me a contributor😂

danwha commented 2 years ago

It's but I can't seem, but using the command line is alot simpler.

Why not make me a contributor😂

I'm not familiar with github. Can you tell me how to set it up?

I found something similar. Would this help? https://github.com/MarcDiethelm/contributing/blob/master/README.md

I added you as a collaborator . I hope this helps.

iamgabrielsoft commented 2 years ago

Yeah I received it..

I haven't had time to push to to the branch, will do tomorrow

iamgabrielsoft commented 2 years ago

I successfully pushed to the repo with the branch "opensource"

I would allow you to do the PR

danwha commented 2 years ago

ok. I saw your edit. thanks.

iamgabrielsoft commented 2 years ago

You haven't merged my branch "opensource"

danwha commented 2 years ago

I don't know how to merge.

If possible, could you please add something interesting? For example, I've been thinking about whether I can apply JWT since yesterday.

iamgabrielsoft commented 2 years ago

Have successfully merged... we now have two branches "open source" and "main"

Well if the JWT sounds good, i will add it to the project

iamgabrielsoft commented 2 years ago

@danwha I need your response on this ☝️☝️

danwha commented 2 years ago

@danwha I need your response on this ☝️☝️

Oh, sorry to see your post late. What is the talk about?

iamgabrielsoft commented 2 years ago

You wanted to add jwt to the library

danwha commented 2 years ago

You wanted to add jwt to the library

Ah... I can't think of it right now. (I'm preoccupied with other things right now.) I don't know how to apply it or if it will be useful.

iamgabrielsoft commented 2 years ago

Am not occupied, though I feel you till need some time to think how you want the package to look like.

Am always open for suggestions

What do you think?