Open rashthedude opened 10 years ago
+1
This would fix #81
Can you add a test?
This would be great
I will add necessary tests.
Any progress?
Sorry, but due to work commitments have I not been able to write the necessary tests. Should hopefully have them ready for the weekend.
Maybe I can help you with the tests? I'd just need to have an example or something, because I've never done tests for node
+1
@capablemonkey Happy to merge if you fancy adding some tests :)
@easternbloc I've been struggling to figure out a way to test this change to be honest. Had a look through the current tests and I didn't see a way of testing an option. Testing setting an agent itself from the response also seems impossible. Any ideas?
We have a requirement such that we need to make non standard HTTPS calls. We need to alter the https agent and pass information on where to read the cert, ca and cert files are not provided by the connection.
An example use case is as follows
The pull request is super simple so would be excellent if you could merge it in.