Fix cannot read file from path using rest.file()

danwrong / restler

REST client library for node.js

MIT License

1.99k stars 391 forks source link

Open lekhacman opened 7 years ago

lekhacman commented 7 years ago

fs.read() expects <Buffer | Uint8Array> at the second arguments (Node 8.x) but received a number.

arbaaz commented 6 years ago

Can we merge this PR?

arbaaz commented 6 years ago

Fatal error: Second argument needs to be a buffer

fpavlik commented 6 years ago

The same problem. binding.read(fd, buffer, offset, length, position, req); TypeError: Second argument needs to be a buffer How to fix it?

lekhacman commented 6 years ago

@fpavlik I have fixed the issue in the pull request but looks like this repository has no maintainer. So, you can go ahead with 2 options:

Use a different, well-maintained library (such as "request"...) (personally recommend this option)
If you want to stick with restler, then use rest.data() instead of rest.file()

fpavlik commented 6 years ago

thanks, men!) Good luck