search

danyaPostfactum / modx-ckeditor

CKEditor integration into MODx Revolution
19 stars 19 forks source link

Update CKEditor to 4.7.1 #34

Closed Boddlnagg closed 6 years ago

Boddlnagg commented 7 years ago

This PR updates the underlying CKEditor to version 4.7.1. Functionality should be unchanged (all the plugins that were previously included are still included). Plugins and languages that are now part of the "Full Package" have been added.

The default skin was changed from moono to moono-lisa in version 4.6, so I included the new default skin in this package. This means that the default value for the ckeditor.skin needed to change. Is this enough to make existing installations automatically change the skin to the new value (at least if the value was never changed)? I'm not familiar enough with MODX package development/deployment to know about the details here.

In my MODX installation, this update fixed a longstanding issue that I was never able to track down, where CKEditor would scroll to the top of the document after applying certain changes (e.g. appyling a heading format).

alex-lenk commented 6 years ago

danyaPostfactum, When will the changes?

danyaPostfactum commented 6 years ago

@alex-lenk I am back now. I'l take care about it in January. @Boddlnagg thanks

alex-lenk commented 6 years ago

Thank you so much. We are all waiting for the update of this plugin, it will eliminate many problems. Best regards!

alex-lenk commented 6 years ago

Даня, подскажи, а как слить данную ветку к себе и собрать пакет? что бы потом установить на сайт

Indigo744 commented 6 years ago

Any news? Looking forward for an update of CKEditor...

danyaPostfactum commented 6 years ago

@Boddlnagg thanks. I have updated to 4.8.0 and cherry-picked "save" fix.