search

danyill / oscd-tp-multicast-naming

Apache License 2.0
3 stars 2 forks source link

CSV Export - Final 3 column headers are incorrect #27

Closed aus-betz closed 1 month ago

aus-betz commented 1 month ago

When using the CSV export feature, the final three column headers are mixed up. Shown order is Min Time, Max Time, ConfRev; whereas the order should be ConfRev, Min Time, Max Time.

image

aus-betz commented 1 month ago

It appears we can blame @jarradraumati for this one! How cool is the blame tool... Line 1418 to be bumped to rows further down. @danyill, I may need a quick lesson on github on how to address easy fixes like this and also how to suggest features.

image

jarradraumati commented 1 month ago

The danger of not having tests and doing quick changes...

Fair straightforward to fix. I'll do a pull request soon.

danyill commented 1 month ago

Thanks for reporting :+1:

I've redeployed to https://transpower-nz.github.io/open-scd/

You may need to do a Ctrl+F5 in your browser to refresh the distribution.

danyill commented 1 month ago

@danyill, I may need a quick lesson on github on how to address easy fixes like this and also how to suggest features.

Sure, we can do a session, send me an invite