danylovolokh / VideoPlayerManager

This is a project designed to help controlling Android MediaPlayer class. It makes it easier to use MediaPlayer ListView and RecyclerView. Also it tracks the most visible item in scrolling list. When new item in the list become the most visible, this library gives an API to track it.
3.15k stars 747 forks source link

The method deactivate() in VisibilityItem.java in "visibility_demo" does not work #21

Open chenyucheng97 opened 8 years ago

chenyucheng97 commented 8 years ago

hi, first,Thanks to your VideoPlayerManger project, it helps me a lot. But when I run your visibility_demo, the overrided method deactive() does not work.only the setActive() works. the deactive() code: @Override public void deactivate(View currentView, int position) { mItemCallback.makeToast("Deactivate View" + position);}

there is no toast, and I am a new fish in developing android,I just down't konw how to figure it.

danylovolokh commented 8 years ago

Deactivate is called when current item should be deactivated but new item is not activated. Yeah, probably not the best implementation

hamidraasti commented 7 years ago

@danylovolokh Hi danylo. what's your suggestion for this issue?! the method is not called even in situation you said: "Deactivate is called when current item should be deactivated but new item is not activated"

even in your sample app. just leave a Log! plz help :) Tnx

hamidraasti commented 7 years ago

@chenyucheng97 Hi. Do you find any way to solve this issue?

hamidraasti commented 7 years ago

We ca do our work in setActive method as we know but I love beautiful code :) and I want to deactivate method work