search

danyspin97 / danyspin97.github.io

2 stars 0 forks source link

rel="feed" is used with Atom feeds #2

Closed Minoru closed 5 years ago

Minoru commented 6 years ago

Your HTML templates include <link rel="feed"> with href pointing to an ordinary Atom feed. According to IndieWeb, rel="feed" should be used with h-feeds, which are totally different from Atom. I'm not aware of any newsreaders that actually support h-feeds, but anyway, this might confuse some of them if they expect h-feed but get Atom instead. Please either change the href or remove those <link>s altogether.

ghost commented 6 years ago

What about change it in:

<link rel="alternate" type="application/rss+xml" title="Feed" href="http://example.com">
Minoru commented 6 years ago

@domcorvasce, similar entry already exists, pointing at https://danyspin97.github.io/index.xml. Or am I misunderstanding your suggestion?

danyspin97 commented 6 years ago

Thank you for pointing this out. I use gohugo to generate the static site and according to gohugo documentation, it uses both rel="feed" and rel="alternate". The html5 documentation suggest the same thing you said, so the best thing to do is pointing this out at gohugo github project.

However I'm really not into html and rss feed to open a well documented issue.

ghost commented 6 years ago

@Minoru you're right. Excuse my ignorance but should be it enough?

Minoru commented 6 years ago

@DanySpin97

according to gohugo documentation, it uses both rel="feed" and rel="alternate".

Not exactly. These lines don't affect Hugo—it will generate the feed anyway. These lines are about linking to that feed, and it's up to you how to do that; the docs merely provide an example. I've opened an issue with Hugo to correct that example.

html-5.com page seem to be based on an 8-year-old HTML5 draft, which differs significantly from the final HTML 5 specification. If you ever need to learn something about HTML again, check out the specification itself—it's up-to-date by definition, and it's surprisingly readable for something so formal ;) @domcorvasce

Sorry, I didn't mean to come across as haughty or snobby. Yes, a single <link> with rel="alternate" is enough.

ghost commented 6 years ago

@Minoru I'm glad you did it, there is always something to learn :smile:

danyspin97 commented 6 years ago

@Minoru First of all, thank you for your detailed explanation. You're right, the problem was in the theme who used the gohugo documentation example. I've opened a pull request to fix this.

I didn't know the HTML 5 specification site but from now on it will be the first site I'll open if I need something about HTML 5.

And it's totally right and not snobby to fix something that's broken.

Minoru commented 6 years ago

Cool! I don't know that much about Hugo, but if I understand this part of the docs correctly, you'll have to add a new section to your config once that PR is merged and you update to new version.

Minoru commented 6 years ago

…Or maybe you won't have to. I'm a bit confused, and I don't want to read any more docs or install Hugo to find out. If any of you understand Hugo well enough, i encourage you to submit a PR to fix gohugoio/hugoDocs#369.

Thanks for discussion, guys!

Minoru commented 5 years ago

Your PR fixing my GoHugo issue was merged, and this issue is fixed by https://github.com/DanySpin97/danyspin97.github.io/commit/c5313e37c34053624acaf50f8fe979f07caef654, so I'm closing it. Thanks for the work! \o/