danyspin97 / rinstall

Declarative install for programs
GNU General Public License v3.0
28 stars 2 forks source link

<pkg-name> usage is inconsistent #13

Open vt-alt opened 1 month ago

vt-alt commented 1 month ago

An additional placeholder used when configuring the directories is ; this will automatically be replaced by the package name used inside install.yml. Some directories (e.g. docdir use this placeholder by default). Manually set the directories to remove it.

Why not to define docdir: @datarootdir@/doc explicitly with <pkg-name> and remove magic of 'manual set'?

Also, Manually set the directories to remove it this does not work and package name is still appended.

For example, by default we install %doc into %_docdir/%name-%version so I try to redefine it for rinstall itself:

+ target/release/rinstall install --packaging --destdir=/usr/src/tmp/rinstall-buildroot --prefix=/usr --docdir=/usr/share/doc/rinstall-0.2.0 --yes
...
Installing README.md -> /usr/src/tmp/rinstall-buildroot/usr/share/doc/rinstall-0.2.0/rinstall/README.md
Installing CHANGELOG.md -> /usr/src/tmp/rinstall-buildroot/usr/share/doc/rinstall-0.2.0/rinstall/CHANGELOG.md

This is incorrect location. Can this be changed to not appending the <pkg-name> if docdir is manually set?