search

danyspin97 / wpaperd

Modern wallpaper daemon for Wayland
GNU General Public License v3.0
332 stars 26 forks source link

Add reload config ability #43

Closed Avimitin closed 1 year ago

Avimitin commented 1 year ago

This PR implements a new IPC command to force wpaperd to reload config. The original proposal for this PR is that the file watcher does not watch the symlink content change, so if the config is symlinked to another file, wpaperd will never know the config has changed.

danyspin97 commented 1 year ago

Thanks for the pull request Avimitin! I have looked into hotwatch and notify crates and there is an issue open for this. We can merge this as a workaround in the meanwhile and we can remove this command later.

Avimitin commented 1 year ago

I've force push new changed, please review the code again. Besides those requested changes, I've also add a new function to WallpaperConfig to compare config by options, instead of the whole struct. Without this change the configuration can be different every time after we load the new configuration.

danyspin97 commented 1 year ago

Thank you for the PR!