danzel / Leaflet.utfgrid

A UTFGrid implementation for leaflet that is super small.
MIT License
132 stars 51 forks source link

remove errored tiles from queue #44

Closed calvinmetcalf closed 9 years ago

calvinmetcalf commented 9 years ago

fixes #43

danzel commented 9 years ago

Thanks @calvinmetcalf

We just merged tileerror support yesterday from @sambernet. @sambernet - could you please check over this?

sambernet commented 9 years ago

Good point!

Fix looks fine. Tested it locally and can

I still see some requests getting "stuck" in the _requests_in_process queue (then piling up in _requests_queue once max in-process requests limit is hit) in the connection timeout case - not completely clear right now, why this happens. Testing by simply taking down the map data backend, so all requests time out eventually.

So there still seems to be an issue here, but can't look into that right now. The changes from @calvinmetcalf should be merged into master anyway.

danzel commented 9 years ago

Awesome thanks. If anyone can look at the timedout requests getting stuck that'd be great.