search

danzel / airtouch5py

Python client for the airtouch 5
Apache License 2.0
5 stars 1 forks source link

Zones in home assistant are only on or off #2

Open AussieMakerGeek opened 6 months ago

AussieMakerGeek commented 6 months ago

Hi, I recently tried out your Airtouch5 integration but for zone control, if you don't have a temperature sensor for that zone, there appears to only be the ability to 'turn the fan on or off', however, this just sets the zone to 0% or 100%. Is there any way this can be changed to a 0-100% scale (even it it was a fan speed in x increments)?

Am I perhaps missing something and you can already do that somehow?

danzel commented 6 months ago

What is in home assistant doesn't support this. But there is support in the library to do it, and I've done the HA side, they just need a lot of tidy up and PR handling

At this commit binary_sensor.py and cover.py (removed in the next commit)

cover allows setting the damper%

https://github.com/danzel/airtouch5py/releases/tag/0.2.8 This old release might do it if it still works. Otherwise please grab those two files, fix them up and PR them to Home Assistant to add it 🙏

AussieMakerGeek commented 6 months ago

Thanks for replying. I'm a little confused (and somewhat out of my depth). So you did add support but then removed it?

I'm not really sure what fixing the files would need.

danzel commented 6 months ago

When you add a new integration to HA you are only allowed to add one entity type, so I had to remove them. I haven't had time to improve and submit adding the entity types since.

AussieMakerGeek commented 6 months ago

I see, I'd love to help but I'm not sure I quite have the skills for that but if you can give me some pointers I am willing to have a go.

Denifia commented 2 months ago

Want a hand with this? I just started using the integration and want damper % control too.

danzel commented 2 months ago

Details are above on what needs to be done @Denifia https://github.com/danzel/airtouch5py/issues/2#issuecomment-2060087684

Denifia commented 2 months ago

@danzel if you have free time, can you cast your eye over my PR linked above.

Denifia commented 2 months ago

This has been merged into the dev branch of home assistant and will roll out to users at some point. Not sure on the timing of that.

@danzel consider closing this issue.