search

dao-to-earth / d2d-deal-v1

D2D Deal Protocol.
https://d2d-deal-v1.web.app/
1 stars 2 forks source link

Willgg/refacto contracts #73

Open Willgg opened 2 years ago

eugenPtr commented 2 years ago

The logic looks good.

However, this doesn't follow the last flow we discussed: anyone can create a proposal then both parties need to approve it within the deadline.

I'm happy to take some weight off your shoulders & create a new branch from this one, implement this flow then submit a PR.

Willgg commented 2 years ago

The logic looks good.

However, this doesn't follow the last flow we discussed: anyone can create a proposal then both parties need to approve it within the deadline.

I'm happy to take some weight off your shoulders & create a new branch from this one, implement this flow then submit a PR.

After some work to code this new workflow, I noticed it is less gas efficient as it requires more transaction and more gas fees. I think the speed vs gas-fees tradeoff may not be worthy. One pain i am trying to solve is how to prevent gas to be spent on proposals if one of the DAOs is not token solvent (has not allowed token to be transfer by us in the ERC20 contract). I opened a discussion on discord about this.