feedback

[luceos]

Hello @daocatt ,

I left some feedback about this extension on the Flarum official community: https://discuss.flarum.org/d/36248-translate-gtdxyzflarum-ext-badges/2

Here's a copy:

Some feedback for you:

• instead of forking the original extension and publishing it under a new name, why did you not improve on the original one and make that one better, aside from the confusion you prevent with users, you wouldn't have had the issue with translations
• although you forked the code from v17, you did not include their copyright information as is required by the same license you included; open source allows you to use code however you want, yet copyrights must remain intact

I applaud any effort to work in open source, make sure you do it respectfully though. Good luck!

[daocatt]

Thanks for reply.

• Some of the settings and features I need are very private ideas, so I don't think it's appropriate to merge them into the original plugin.
• I will add source code information later.

Thanks again.