search

daohoangson / flutter_widget_from_html

Flutter package to render html as widgets that supports hyperlink, image, audio, video, iframe and many other tags.
https://pub.dev/packages/flutter_widget_from_html
MIT License
635 stars 235 forks source link

Expand roman support to 3999 #1154

Closed ngthailam closed 9 months ago

ngthailam commented 9 months ago

Closes #639

Changes

Add function to convert int to roman numerals ( from 1 to 3999 )

Also:

Screenshot

Screenshot 2024-01-10 at 14 56 40

ngthailam commented 9 months ago

This is a nice package so I'd like to contribute, I took the liberty to address this issue https://github.com/daohoangson/flutter_widget_from_html/issues/639

I'm not yet familiar with the coding style/conventions of this package, so please drop a review if you see any issues.

Please have a look @daohoangson Thanks

daohoangson commented 9 months ago

This looks great, thank you for the contribution. I have kicked off the pipeline runs, if they are all green then I'll merge it.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (83c67e7) 99.58% compared to head (fb379ec) 99.58%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1154 +/- ## ======================================= Coverage 99.58% 99.58% ======================================= Files 71 72 +1 Lines 4328 4334 +6 ======================================= + Hits 4310 4316 +6 Misses 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

daohoangson commented 9 months ago

Sorry, the demo screen is too long so I had to revert that file.

ngthailam commented 9 months ago

@daohoangson no problem