Closed ngthailam closed 9 months ago
@daohoangson Please have a look at the PR, simple fix but solves noticeable problem when running the Demo App.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2dc197d
) 99.58% compared to head (882ee43
) 99.58%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is great! I have merged the PR, thank you very much.
General:
Running on IOS simulator Closes #980 Closes #981
Describe problem:
980: Due to Slider assert constructor, when max == 0 and value == 0, it throws
981: Same issue, only when back to home_page, the slider max && value is reset to 0, causing the same exception but in a different screen
🔔 This affects not just the Demo app, but anywhere which has the same html element.
Changes:
UI Evidence:
Before:
https://github.com/daohoangson/flutter_widget_from_html/assets/48094980/dd7d0016-b563-40e4-8874-4d22ff909988
After
https://github.com/daohoangson/flutter_widget_from_html/assets/48094980/8d8954fa-6ead-4a97-adb9-0f9e9c882361