daohoangson / flutter_widget_from_html

Flutter package to render html as widgets that supports hyperlink, image, audio, video, iframe and many other tags.
https://pub.dev/packages/flutter_widget_from_html
MIT License
635 stars 235 forks source link

Feature add support text-shadow style #1158

Closed ngthailam closed 9 months ago

ngthailam commented 9 months ago

Add support for https://github.com/daohoangson/flutter_widget_from_html/issues/586

The structure is kinda new to me, so please take a look and feel free to drop comments, i'll try to address them. I follow the examples + rules here https://developer.mozilla.org/en-US/docs/Web/CSS/text-shadow

Changes:

daohoangson commented 9 months ago

This looks great already. We need tests to cover different combinations of the shadow I think.

ngthailam commented 9 months ago

@daohoangson Cool if the code looks good, I'll start on writing the tests. Will update you after done

daohoangson commented 9 months ago

Thank you.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dcdada3) 99.58% compared to head (98f4c2a) 99.58%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1158 +/- ## ======================================= Coverage 99.58% 99.58% ======================================= Files 72 74 +2 Lines 4335 4379 +44 ======================================= + Hits 4317 4361 +44 Misses 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

daohoangson commented 9 months ago

Please ignore the flaky iOS integration test, I'm working on that at #1141.

There are only 2 uncovered lines left, can you take a look?

Screenshot 2024-01-13 at 16 50 17

I think adding a test case with multiple shadows should be enough.

ngthailam commented 9 months ago

@daohoangson I have added the extra test case

ngthailam commented 9 months ago

I have added the changes according to the review, please have a look