Closed ngthailam closed 9 months ago
This looks great already. We need tests to cover different combinations of the shadow I think.
@daohoangson Cool if the code looks good, I'll start on writing the tests. Will update you after done
Thank you.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
dcdada3
) 99.58% compared to head (98f4c2a
) 99.58%. Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please ignore the flaky iOS integration test, I'm working on that at #1141.
There are only 2 uncovered lines left, can you take a look?
I think adding a test case with multiple shadows should be enough.
@daohoangson I have added the extra test case
I have added the changes according to the review, please have a look
Add support for https://github.com/daohoangson/flutter_widget_from_html/issues/586
The structure is kinda new to me, so please take a look and feel free to drop comments, i'll try to address them. I follow the examples + rules here https://developer.mozilla.org/en-US/docs/Web/CSS/text-shadow
Changes: