daohu527 / cyber_record

cyber_record offline parse tool
Apache License 2.0
52 stars 19 forks source link

Remove print(header) from reader or use a flag to control #38

Closed YuqiHuai closed 2 years ago

YuqiHuai commented 2 years ago

Hi!

Thank you for the great tool!

I am wondering if the following line https://github.com/daohu527/cyber_record/blob/b00546d041f382793a9f2454f1a8bf7c3722ce79/cyber_record/reader.py#L56

should be removed or controllable through a boolean flag, so it does not print information to the console if I do not need it.

daohu527 commented 2 years ago

Thanks for your advice! Next step, I will repalce print to log. Maybe this weekend.

YuqiHuai commented 2 years ago

Great! Thanks! I have been using your tools and they work well so far. I temporarily commented out the line myself.

daohu527 commented 2 years ago

fixed the log, and you can update the new version pip3 install cyber_record -U