search

daokoder / dao-modules

Dao Standard Modules
http://daovm.net
12 stars 5 forks source link

default umask (file/dir mode) #64

Closed dumblob closed 9 years ago

dumblob commented 9 years ago

Currently s_IRWXU|S_IRGRP|S_IXGRP|S_IXOTH permissions are used in FS_Mkdir(), but this feels inconsistent:

  1. default configuration on most Linux/UNIX distributions (umask 022 is the most common) - but I personally don't like 022, because it's not secure
  2. it doesn't make much sense to me - either we should fully obey global umask setting or we should set group permissions to rwx (S_IRWXG) just like user permissions (this is secure and is used also on production servers)
Night-walker commented 9 years ago

Changed the group part to S_IRWXG.

dumblob commented 9 years ago

Fixed.