search

daomapsieucap / fiber-admin

💈 Bring multiple customization features to make your own WordPress admin.
https://wordpress.org/plugins/fiber-admin/
0 stars 1 forks source link

Wrong Data in Meta Fields #18

Closed phongkhuu115 closed 1 year ago

phongkhuu115 commented 1 year ago

@daomapsieucap I have finished fixing the bug which makes meta fields not correctly input. Can you please look over it, thank you!!

The main idea of mine is: The filename was correctly sanitized, so I use the filename to form the metadata.

daomapsieucap commented 1 year ago

Not sure that you've tested your code carefully but it didn't work properly, see my screenshot Screenshot_336

phongkhuu115 commented 1 year ago

@daomapsieucap The function name was fiad_set_image_meta_on_image_upload() so I think this only applied for images only, so I keep the condition wp_attachment_is_image($post_id) which result in the wrong title field of others type of file, I have removed it, now it works for every file type, can you check again? Thank you!

daomapsieucap commented 1 year ago

Close with updated in issue description since we will merge the code to handle attachment in one file.