daomapsieucap / fiber-admin

💈 Bring multiple customization features to make your own WordPress admin.
https://wordpress.org/plugins/fiber-admin/
0 stars 1 forks source link

term_order in CPT detail not working #6

Open daomapsieucap opened 2 years ago

daomapsieucap commented 2 years ago

Feature request

daomapsieucap commented 1 year ago

@phongkhuu115 Check if all the features requested are implemented or not.

Currently, we did have a bug existing: When we have existing terms (without enabling term_order before creating these terms), then we enable term_order in Fiber Admin. The terms won't go in the correct order. I think because Fiber Admin doesn't create / update correct term_order when we enable term_order with existing term.

phongkhuu115 commented 1 year ago

@daomapsieucap I don't think the issue still exists, as soon as I turn the feature on for the new create taxonomy, all its terms are automatically sorted by their term_order

daomapsieucap commented 1 year ago

@phongkhuu115 I confirmed that the issue still exists. Please try to re-produce all the steps I mentioned and show terms on FE using term_order. "The terms won't go in the correct order" will happen on FE.

phongkhuu115 commented 1 year ago

@daomapsieucap May I ask for more details? Because I can't reproduce the problem

This is what I have done:

  1. Create new Taxonomy and CPT
  2. Create a number of terms
  3. Show terms on FE by term_order
  4. Enable drag-and-drop for Taxonomy
  5. Shuffle order

But I don't see any problem.

Newly created (no change is made): This look correct because default it's order by name

image

Show on FE: I used term_order here

image

Enable drag and drop:

image

Show on FE: Although all term order is 0, but it's the same with admin site

image

My test code:

image