search

daostack / access_control

GNU General Public License v3.0
1 stars 1 forks source link

Solve capability escalation problem #11

Closed ben-kaufman closed 6 years ago

ben-kaufman commented 6 years ago

Solved capability escalation problem by disallowing tranfering key to an accout which already have a matching key. Replaced lock and transfer mechanism with setKey. Added test cases. Added eth-gas-reporter for testing.

tsuberim commented 6 years ago

I'll make a PR of my own soon which integrates some of those changes.

ben-kaufman commented 6 years ago

I fixed the bugs and removed the last commits.

ben-kaufman commented 6 years ago

@dev-matan-tsuberi PR for which changes?

tsuberim commented 6 years ago

I was already working on another PR, so I'm just to implement some of your changes in there.

ben-kaufman commented 6 years ago

Ok

orenyodfat commented 6 years ago

Why lib Math is needed ?

orenyodfat commented 6 years ago

Do we need toBytes function to be public ? Do we need that at all ?

ben-kaufman commented 6 years ago

@orenyodfat Is there anything more to fix? If not please approve and I'll merge it.

orenyodfat commented 6 years ago

👍