search

daostack / access_control

GNU General Public License v3.0
1 stars 1 forks source link

`expiration` should be a block number instead of timestamp #9

Closed tsuberim closed 6 years ago

tsuberim commented 6 years ago

Miners can influence timestamp to some extent.

leviadam commented 6 years ago

@dev-matan-tsuberi
This issue is a known one and the question keeps repeating itself, for every use-case, what is better. A timestamp can be manipulated (a few seconds). However, predicting when a block will happen is much less accurate. In some sense, if you do not care much when something will happen, as long as everyone agrees about it and cannot manipulate it, block-number is better. If however, it is more important to allow a predictable time, a timestamp is better.

In our case, I think the latter is more correct.