daostack / alchemy

An app for collaborative networks (DAOs), based on the DAO stack.
https://alchemy.do
GNU General Public License v3.0
144 stars 80 forks source link

define what to do on network/account changes #294

Closed jellegerbrandy closed 5 years ago

jellegerbrandy commented 5 years ago

Alchemy gets its current state from an external provider (metamask for now, portis maybe as well later).

the user can change this while using the app. Alchemy used to reload the entire app when he accountchanges, which seems a bit overkill. Here's a proposal:

(1) quick iteration one: we reload just as alchemy does

(2) ideal behavior:

tibetsprague commented 5 years ago

Alchemy used to only update some parts when account changed but there kept being edge cases that we missed so thats why we decided to just reload... we can try again but doesnt seem like high priority right now to make this work. people won't change their accounts very often either, only devs

jellegerbrandy commented 5 years ago

related: #326 and #338

A-Zak commented 5 years ago

227 also related :)

jellegerbrandy commented 5 years ago

I'm closing this as we have something working now, even if it is not ideal :-)