Add vote and votes methods to `ICompetitionSuggestion`

[dkent600]

Would be nice if ICompetitionSuggestion contained the vote and votes methods. I guess this is an effect of how the client lib entities are architected in general, where entity's static and dynamic properties are stored in class fields rather than the class itself, whereas the entity methods are stored elsewhere in the class. This is awkward for the user to code and not intuitive as it does not follow the usual object-oriented design pattern everyone is used-to.

[jellegerbrandy]

I think there is a clear pattern, and i am not sure what "usual object-oriented design pattern averyone is used to" you mean that we can use here (but I am curious to learn, because I agree that there is something a bit awkward here)

explanation:

• So the entitites of the client are object that (a) you can use to read info from the subgraph and (b) to send transacdtions to the blockchain
• Typically, you'd instantiate the objects like this: new Entity(id)
• (note that constructors cannot be async, so we cannot read any data here)
• entity instances have methods to read data from the chain, for example, there is proposal.votes(), proposal.stakes() and proposal.state()
• entity instances ahve methods to write, such as propsoal.vote() etc.
• As a convention, entity.state() returns an (observalve of) a IEntityState interface. This is just the "flat" state.
• I (just) changed the interface name from ICompetitionSuggestion to ICompetitionSuggestionState, just to avoid confusion here

So, with that terminlogy, what you are proposing (perhaps) is to have a pattern that looks like this:

class Entity implements IEntityState

public state(): Observable<Entity>

Is that what you hae in mind?