Diffrentitate between a "new" item and an item marked "unseen"

daostack / common-web

The web UI for the Common project

https://common.io

1 stars 0 forks source link

Diffrentitate between a "new" item and an item marked "unseen" #2221

Closed elatif2020 closed 1 year ago

elatif2020 commented 1 year ago

We should have different appearance in the FE for items which are "new" for a user and items which were marked as unread. Currently what I see is:

"new" items don't have a badge (for other users) before a message is sent.
once a message is sent in a "new" item it appears with "mark unseen" badge instead as new.

I'm not sure whether the issue is in the FE or BE. currently opening in the BE, but could be good if also someone from the FE could have a look.

danielr18 commented 1 year ago

The commonFeedObjectUserUnique object has seen and seenOnce. If seen is false, then it's unread. If seenOnce is false, then it's new.

budnik9 commented 1 year ago

@danielr18 The problem is that the backend returns wrong values of these flags. For example, I have two users User 1 and User 2

User 1 creates a discussion in a space.
User 2 opens this space and sees newly created discussion but without New tag, because the seenOnce flag value is true

Also there is one more strange behavior: If User 1 writes a message in this discussion, User 2 will see unseen tag on the discussion. And that's a data problem, too (count is 0, seen is false, seenOnce is undefined).

cc @elatif2020

elatif2020 commented 1 year ago

If I understand correctly this issue was taken care of from the BE side in https://github.com/daostack/common-web/issues/2233 and was transferred to the FE. So I am closing current ticket as a duplication.