search

daostack / infra

GNU General Public License v3.0
25 stars 22 forks source link

rename GenesisProtocolExecuteInterface and GenesisProtocolCallbacksInterface #10

Closed dkent600 closed 6 years ago

dkent600 commented 6 years ago

All of voting machines assume that the contract using them is implementing GenesisProtocolExecuteInterface and GenesisProtocolCallbacksInterface.

Do the names of these interfaces really imply anything about GenesisProtocol or voting machines/schemes in general?

Would it make more sense to be named something more generic like ProposalExecuteInterface and ContractCallbacksInterface?

Otherwise it is confusing to those reading the code, and we could do well to document the reasons behind the naming.

orenyodfat commented 6 years ago

ProposalExecuteInterface VotingCallbacksInterface