Generalized the Voting Machine callback interface

daostack / infra

GNU General Public License v3.0

25 stars 22 forks source link

Open ben-kaufman opened 6 years ago

ben-kaufman commented 6 years ago

Generalized the Voting Machine callback interface to match both reputation and other voting.

Removed unnecessary voteWithSpecifiedAmounts() token parameter.

Seperated Voting Machine Callback Interface from Genesis Protocol Callback Interface.

Fixed bug in the AbsoluteVote internalVote function VoteProposal event.

orenyodfat commented 6 years ago

Please explain the use case for "other voting" .
What is the bug at the "AbsoluteVote internalVote function VoteProposal event" ?

ben-kaufman commented 6 years ago

Using anything which has balances (reputation, tokens, etc.), just making Infra more generalized.
The event was emitting reputation variable which was the user's total reputation instead of rep which is the reputation amount the user actually voted with.